Add touch ic suspend feature #6618
Merged
+93
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anjana348
reviewed
Jan 9, 2025
ewoodev
force-pushed
the
WORK-250107_ist415_knock_knock
branch
3 times, most recently
from
69bed5a to
3a87156
Compare
| } | ||
|
|
||
| if (ioctl(fd, TSIOC_SUSPEND, NULL) != OK) { | ||
| printf("Fail to TSIOC_SUSPEND %s, errno:%d\n", TOUCH_DEV_PATH, get_errno()); |
There was a problem hiding this comment.
When the ioctl is failed, it also returns OK. Is this ok?
| @@ -196,10 +229,14 @@ int touchscreen_main(int argc, char *argv[]) | |||
| } | |||
|
|
|||
| if (argc == 2) { | |||
| if (!strcmp(argv[1], "start")) { | |||
| if (!strncmp(argv[1], "start", 5)) { | |||
There was a problem hiding this comment.
This will allow "touchscreen startaaa". Is this ok?
There was a problem hiding this comment.
The svace is detecting it. so i changed
There was a problem hiding this comment.
oh I missed updersdanding, i got your point, I changed len
| @@ -503,14 +523,18 @@ static void ist415_stop_device(struct ist415_dev_s *dev) | |||
| ist415_disable(dev); | |||
| ist415_power_off(dev); | |||
| } | |||
|
|
|||
| return OK; | |||
There was a problem hiding this comment.
Could you let me know why you change the return type even this returns OK always?
There was a problem hiding this comment.
This is ops in touchscreen, so some touch ic might have return fail
ewoodev
force-pushed
the
WORK-250107_ist415_knock_knock
branch
2 times, most recently
from
a1a5bfe to
ea1d752
Compare
sunghan-chang
previously approved these changes
Jan 21, 2025
The touch device suspend feature is changing power mode to low power mode. In the low power mode, power comsumption is reduced and touch irq is not comming. But ist415 ic is checking double tap during low power mode, and it notify to apps the double tab event. In this commit, Add ioctl to control touch ic suspend/resume and example app Signed-off-by: eunwoo.nam <[email protected]>
The suspend test is changing touch ic power mode NP(normal power) to LP (low power) In the commit, Add tash command "touchscreen suspend" and "touchscreen resume" Signed-off-by: eunwoo.nam <[email protected]>
In the ist415_forced_release function data.npoints can be 0. (There is no pushed touch point) But, since touch is reported even if touch point count is 0. Therefore, fix wrong null touch event Signed-off-by: eunwoo.nam <[email protected]>
ewoodev
force-pushed
the
WORK-250107_ist415_knock_knock
branch
from
ea1d752 to
ceda8e0
Compare
sunghan-chang
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.